What is somethings that girls think are attractive?

Does confidence, looks or just things he does matter or what should I change. My traits are I'm athletic, polite,humble,can admit when I'm wrong and funny but idk of I'm the problem or I'm just looking in the wrong places.